Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prefer-primordials): Force to use null [[Prototype]] object #1307

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix(prefer-primordials): Force to use null [[Prototype]] object #1307

merged 2 commits into from
Oct 14, 2024

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Aug 13, 2024 •
edited
Loading

@petamoriken petamoriken force-pushed the fix/prefer-primordials-null-proto branch from 2c73973 to 310105a Compare August 14, 2024 11:32
@petamoriken petamoriken force-pushed the fix/prefer-primordials-null-proto branch from 310105a to d9d4456 Compare August 14, 2024 11:36
@petamoriken petamoriken mentioned this pull request Aug 14, 2024
Merged
@petamoriken petamoriken marked this pull request as ready for review August 14, 2024 11:59
marvinhagemeister pushed a commit to denoland/deno that referenced this pull request Sep 6, 2024
@petamoriken @lucacasonato
fix(runtime): use more null proto objects again (#25040)
f0a3d20 
proceed with #23921

This PR is a preparation for
denoland/deno_lint#1307

---------

Signed-off-by: Kenta Moriuchi <moriken@kimamass.com>
Co-authored-by: Luca Casonato <hello@lcas.dev>
@petamoriken
Copy link
Contributor Author

@magurotuna Please take a look in your time!

@petamoriken petamoriken force-pushed the fix/prefer-primordials-null-proto branch from d9d4456 to 12a918e Compare October 10, 2024 18:09
@petamoriken petamoriken force-pushed the fix/prefer-primordials-null-proto branch from 12a918e to 8545e10 Compare October 10, 2024 18:18
magurotuna
magurotuna approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magurotuna magurotuna merged commit f3fc061 into denoland:main Oct 14, 2024
6 checks passed
@petamoriken petamoriken deleted the fix/prefer-primordials-null-proto branch October 14, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-primordials: Add check for applying null [[Prototype]] objects to {Object,Reflect}.defineProperty
2 participants
@petamoriken @magurotuna