Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve_dependency considers synthetic imports #67

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix: resolve_dependency considers synthetic imports #67

merged 1 commit into from
Nov 8, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Nov 8, 2021

When resolving the jsxImportSource for tsc, we need the ability to resolve dependencies from a synthetic module, so we can "find" the jsxImportSource configured from a set of compiler options.

@kitsonk kitsonk mentioned this pull request Nov 8, 2021
Merged
dsherret
dsherret approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 69b4cf6 into denoland:main Nov 8, 2021
@kitsonk kitsonk deleted the fix_resolve_dep_synthetic branch November 8, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitsonk @dsherret @lucacasonato