Add support for "react-jsx" and jsxImportSource #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yacinehmito
reviewed
Oct 12, 2023
| @@ -0,0 +1,107 @@ | |||
| import { | |||
There was a problem hiding this comment.
You can use the snapshot tests instead so that you don't have to setup output fixtures nor repeat the logic that calls transpile. It will also cover bundle.
There was a problem hiding this comment.
Bundle doesn't seem to work with react-jsx and react-jsxdev.
It throws an error (Error: Unable to output during bundling).
This can be avoided by explicitly declaring the import source with /** @jsxImportSource https://esm.sh/react@17.0.2 */ in the input file.
Apparently, this issue has already been fixed for deno bundle (denoland/deno#13389).
Does this have to be implemented again for deno_emit?
|
Thanks! Landed this in #161 with attribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See #10)
This exposes the
jsxImportSourcecompiler option and allows thejsxoption to be"preserve" | "react-jsx" | "react-jsxdev" | "react-native" | "react"