Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rework the resource read/write resource routines #440

Closed
wants to merge 6 commits into from
Closed

[WIP] Rework the resource read/write resource routines #440

wants to merge 6 commits into from
+1,884 −678

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Jan 13, 2024 •
edited
Loading

TODO:

  • Add read/write interest to resource handles if an implementation doesn't want both
  • read_all
  • write_all
  • benchmark

@mmastrac mmastrac mentioned this pull request Jan 15, 2024
Closed
@mmastrac mmastrac mentioned this pull request Jan 24, 2024
Merged
mmastrac added a commit that referenced this pull request Jan 24, 2024
@mmastrac
refactor(core): split up resource code and add a resource test (#472)
1051b6c 
Partially extracted from #440

Also pulls in `BufMutViewWhole` from that PR that will be required for
buffer soundness in a later PR -- you should not split a buffer that is
owned by JavaScript.
@mmastrac mmastrac closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmastrac