Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error on 'null' key in exports #26

Merged
merged 3 commits into from
Jan 13, 2024
Merged

fix: error on 'null' key in exports #26

merged 3 commits into from
Jan 13, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 27, 2023 •
edited
Loading

serde deserializes null for Option<serde_json::Value> as None instead of Some(serde_json::Value::Null) (which can't kind makes sense I think), so I just can't add a test for "exports": null

@dsherret

This comment was marked as outdated.

Sign in to view
@dsherret dsherret merged commit 3f5c6e2 into denoland:main Jan 13, 2024
3 checks passed
@dsherret dsherret deleted the move_null_case_error branch January 13, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju