feat: use deno_error crate #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
commented
Nov 14, 2024
| #[error(transparent)] | ||
| SwcEmit(std::io::Error), | ||
| SwcEmit(#[inherit] std::io::Error), | ||
| #[class(TYPE)] | ||
| #[error(transparent)] | ||
| SourceMap(sourcemap::Error), |
There was a problem hiding this comment.
not sure if we want to have this be a TypeError or handle all the sourcemap::Error variants, especially since it has a std::io::Error variant
dsherret
reviewed
Nov 14, 2024
dsherret
reviewed
Nov 21, 2024
| @@ -17,9 +14,13 @@ use crate::ModuleSpecifier; | |||
| use crate::SourceRange; | |||
| use crate::SourceRangedForSpanned; | |||
| use crate::SourceTextInfo; | |||
| use deno_error::JsError; | |||
| use std::borrow::Cow; | |||
| use std::fmt; | |||
There was a problem hiding this comment.
Why move this here? One day we'll get this formatting in this repo: denoland/deno#26646
There was a problem hiding this comment.
i didnt, cargo fmt did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.