Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Program instead of Module more #281

Merged
merged 6 commits into from
Oct 28, 2024
Merged

feat: use Program instead of Module more #281

merged 6 commits into from
Oct 28, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 21, 2024 •
edited
Loading

This is going to help with CJS support.

@dsherret dsherret mentioned this pull request Oct 21, 2024
Merged
@dsherret dsherret mentioned this pull request Oct 25, 2024
Merged
@dsherret dsherret requested a review from bartlomieju October 28, 2024 15:48
@dsherret dsherret marked this pull request as ready for review October 28, 2024 15:48
bartlomieju
bartlomieju approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's go

@dsherret dsherret merged commit 64c454f into denoland:main Oct 28, 2024
2 checks passed
@dsherret dsherret deleted the feat_use_program_more branch October 28, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju