Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: tokio 1.0 #8779

Merged
merged 22 commits into from
Jan 12, 2021
Merged

upgrade: tokio 1.0 #8779

merged 22 commits into from
Jan 12, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 15, 2020 •
edited
Loading

This commit upgrades all crates to "tokio 1.0" along with
crates from tokio ecosystem.

@bartlomieju bartlomieju mentioned this pull request Dec 17, 2020
Closed
22 tasks
@yos1p yos1p mentioned this pull request Dec 25, 2020
Closed
@yos1p
Copy link
Contributor

yos1p commented Dec 25, 2020

I would like to help with upgrading test_util crate to tokio 1. #8885

@kitsonk kitsonk changed the title [WIP] upgrade: tokio 0.3 [WIP] upgrade: tokio 1.0 Dec 25, 2020
@lucacasonato lucacasonato mentioned this pull request Dec 26, 2020
Closed
@protheory8
Copy link

Is this PR still blocked by #8512?

@bartlomieju
Copy link
Member Author

Is this PR still blocked by #8512?

No, we're waiting for releases of reqwest and tokio-tungstenite

@caass
Copy link

caass commented Dec 29, 2020

links for me and/or others: tokio-tungstenite#142, reqwest#1076

@magurotuna magurotuna mentioned this pull request Jan 4, 2021
Merged
@bartlomieju bartlomieju changed the title [WIP] upgrade: tokio 1.0 upgrade: tokio 1.0 Jan 9, 2021
@bartlomieju
Copy link
Member Author

In net_test.ts there is a hang in netHangsOnClose. It is op_read that is hanging. Interesting finding is that if I close the connection from the other side (the side that wrote bytes op_read is hanging on) then op_read immediately unhungs.

@piscisaureus piscisaureus merged commit 275a5c6 into denoland:master Jan 12, 2021
@bartlomieju bartlomieju deleted the tokio_03 branch January 12, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bartlomieju @yos1p @protheory8 @caass @piscisaureus