Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Compiler config in Rust #7228

Merged
merged 25 commits into from
Aug 31, 2020
Merged

refactor: Compiler config in Rust #7228

merged 25 commits into from
Aug 31, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 28, 2020 •
edited
Loading

Closes #5606

kitsonk
kitsonk reviewed Aug 29, 2020
View reviewed changes
cli/tsc.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju changed the title refactor: Compiler config [WIP] refactor: Compiler config Aug 29, 2020
@bartlomieju
Copy link
Member Author

@kitsonk all configuration has been moved to Rust (cli/tsc.rs) - I kept the logic exactly as was in cli/tsc/99_main_compiler.js - I guess it can be simplified with next passes.

Please review and let me know if this patch is satisfactory.

CC @ry also please review

@bartlomieju bartlomieju changed the title [WIP] refactor: Compiler config refactor: Compiler config in Rust Aug 30, 2020
@bartlomieju bartlomieju mentioned this pull request Aug 30, 2020
Closed
kitsonk
kitsonk reviewed Aug 30, 2020
View reviewed changes
cli/msg.rs Outdated Show resolved Hide resolved
cli/tsc.rs Outdated Show resolved Hide resolved
cli/tsc.rs Outdated Show resolved Hide resolved
cli/tsc/99_main_compiler.js Outdated Show resolved Hide resolved
@bartlomieju bartlomieju requested a review from ry August 31, 2020 09:19
ry
ry reviewed Aug 31, 2020
View reviewed changes
cli/tsc_config.rs Show resolved Hide resolved
ry
ry reviewed Aug 31, 2020
View reviewed changes
cli/tsc_config.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit c82c3b9 into denoland:master Aug 31, 2020
@bartlomieju bartlomieju deleted the compiler_config branch August 31, 2020 18:12
This was referenced Mar 12, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move config parsing out of js/compiler.ts
3 participants
@bartlomieju @ry @kitsonk