Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-check docs #6714

Merged
merged 7 commits into from
Jul 13, 2020
Merged

--no-check docs #6714

merged 7 commits into from
Jul 13, 2020

Conversation

lucacasonato
Copy link
Member

Closes #6713

@bartlomieju
Copy link
Member

We should also mention that developers should use import type and export type for type-only imports/export; otherwise using --no-check will lead to errors as described by @kitsonk in #6456

Please mention config we use in std/ that ensures modules can be safely transpiled:

{
  "compilerOptions": {
    "importsNotUsedAsValues": "error"
  }
}

@kitsonk
Copy link
Contributor

kitsonk commented Jul 12, 2020

The other thing that is "banned" in transpile only is const enum (as well as the legacy export = and import = TypeScript syntax which is really obscure, and I doubt anyone is trying to use that in Deno, but for completeness 🤷 )

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@ry ry merged commit ac00034 into denoland:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs --no-check option
4 participants