Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote .wasm import content type issue #3351

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Fix remote .wasm import content type issue #3351

merged 1 commit into from
Nov 15, 2019

Conversation

kevinkassimo
Copy link
Contributor

Fix remote wasm import:

./tools/http_server.py &
./target/debug/deno https://raw.githubusercontent.com/denoland/deno/master/cli/tests/051_wasm_import/simple.wasm

ry
ry approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @kevinkassimo manual documentation for wasm import would be appreciated - features are not visible to many people until they are in the manual.

@ry ry merged commit 306ab01 into denoland:master Nov 15, 2019
@kevinkassimo
Copy link
Contributor Author

@ry I believe @hayd is working on that. See #2552

bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@kevinkassimo @bartlomieju
Fix remote .wasm import content type issue (denoland#3351)
cba2882
@sithumonline sithumonline mentioned this pull request May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinkassimo @ry