Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make deno_runtime::shared module public #27242

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

theswerd
Copy link
Contributor

@theswerd theswerd commented Dec 5, 2024

Making shared public in deno_runtime

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was discussed in #dev channel on Discord

cli/lib.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops - done

@bartlomieju bartlomieju marked this pull request as draft December 5, 2024 23:12
@bartlomieju bartlomieju changed the title Feat: Public Transpile Func refactor: Make deno_runtime::shared module public Dec 5, 2024
Signed-off-by: Benjamin Swerdlow <Swerdlowbenjamin@gmail.com>
@theswerd theswerd marked this pull request as ready for review December 6, 2024 09:52
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartlomieju bartlomieju enabled auto-merge (squash) December 9, 2024 15:14
@bartlomieju bartlomieju merged commit d7dfd4b into denoland:main Dec 9, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Dec 11, 2024
Signed-off-by: Benjamin Swerdlow <Swerdlowbenjamin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants