refactor(ext): align error messages #25914
Conversation
Aligns the error messages in the ext folder to be in-line with the Deno style guide. denoland#25269
| } | ||
|
|
||
| if (cert !== undefined && key === undefined) { | ||
| throw new TypeError( | ||
| `If \`cert\` is specified, \`key\` must be specified as well for \`${api}\`.`, | ||
| `If \`cert\` is specified, \`key\` must be specified as well for \`${api}\``, |
There was a problem hiding this comment.
We're using double quotes for option KeyFormat, but using backquotes for cert. Should we make them consistent?
There was a problem hiding this comment.
Good catch. We didn't really specify which quoting style we want and things are all over the map. I've been trying to remove the forward tick style as that wasn't used much. I've been trying to align on double quotes, but I know that it's a bit of a mixed bag.
I guess this particular rule could be specified with a linter rule, but that would likely cause the entire code base to fail and would require a rather large change-set to align everything. I'm not sure that's worth it.
That's a long way of saying I'll move to double quotes here, and if we want to align the entire code base we can file an issue and weigh the benefits.
Aligns the error messages in the ext folder to be in-line with the Deno style guide.
#25269