Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(console): remove Deno.customInspect #25348

Merged
merged 3 commits into from
Sep 3, 2024
Merged

BREAKING(console): remove Deno.customInspect #25348

merged 3 commits into from
Sep 3, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 2, 2024 •
edited
Loading

Note: this is implemented on Deploy. However, according to @magurotuna, a thin compatibility layer might be in the works that'd prevent breakages for PRs such as this one.

Towards #22079

@iuioiua iuioiua mentioned this pull request Sep 2, 2024
Closed
@iuioiua iuioiua changed the title chore(console): remove Deno.customInspect BREAKING(console): remove Deno.customInspect Sep 3, 2024
@bartlomieju
Copy link
Member

However, according to @magurotuna, a thin compatibility layer might be in the works that'd prevent breakages for PRs such as this one.

Yes, a customInspect: SymbolFor("Deno.privateCustomInspect") should be enough for everything to work correctly.

@iuioiua iuioiua enabled auto-merge (squash) September 3, 2024 08:33
lucacasonato
lucacasonato approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 1a82b0f into denoland:main Sep 3, 2024
17 checks passed
@iuioiua iuioiua deleted the remove-deno-customInspect branch September 3, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iuioiua @bartlomieju @lucacasonato