fix(ext/node/net): emit error before close when connection is refused

[kt3k]

This PR delays the timing of callback called in socket._handle.close(cb) call, and causes error event happens before close event when socket.destroy() is called.

• This prevents uncaught error with npm:mongodb package (A node.js stream polyfill issue: the error thrown within the process.nextTick callback cannot be caught, leading to unexpected exit when connection closed #24376, error: Uncaught Error: read ECONNRESET #19078).

closes #24376
closes #23665
closes #21951
closes #19078

Note: The changes in unit_node/tls_test.ts, unit_node/http_test.ts, and polyfills/dgram.ts were needed for avoiding op leak error in testing. They are not directly related to the fix.

TODO:

• enable test cases Write test cases (I couldn't find the exact test case which exercise this behavior of net.createConnection in node.js native test cases)

[kt3k]

@bartlomieju PTAL

[bartlomieju]

LGTM, thanks for looking into this one!

[bartlomieju]

Have you tried using nextTick instead?

[kt3k]

nextTick doesn't delay enough because emitErrorNT (which causes error event) callback is called at next tick (and that's registered after _handle.close callback.

deno/ext/node/polyfills/net.ts

Lines 1418 to 1426 in 29934d5

	this._handle.close(() => {
	this._handle!.onread = _noop;
	this._handle = null;
	this._sockname = undefined;
	debug("emit close");
	this.emit("close", isException);
	});
	cb(exception);

In the above code, the callback for this._handle.close is the one delayed in this PR (that emits close). cb in the above is onDestroy in _stream.mjs, which calls process.nextTick(() => stream.emit("error")).

So we need to delay the close callback at least 2 ticks.

[kt3k]

I updated the line to nextTick(nextTick, cb) which also seems working, and also feels more accurate/predictable than setTimeout.