fix(cli): add NAPI support in standalone mode #24642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mutefish0
force-pushed
the
fix-standalone-napi
branch
from
aadf709
to
b82a59d
Compare
devsnek
approved these changes
Jul 21, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Jul 22, 2024
Currently, importing Node-Addons modules in a standalone binary results in a `missing symbol called` error (#24614). Because the NAPI symbols are not exported in this mode. This PR should fix the issue.
bartlomieju
added a commit
that referenced
this pull request
Jul 22, 2024
This reverts commit 4e8f587.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Jul 23, 2024
This reverts commit 4e8f587.
bartlomieju
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit 4e8f587. Reverting because, it caused a failure during v1.45.3 publish: https://github.com/denoland/deno/actions/runs/10048730693/job/27773718095 CC @Mutefish0
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, importing Node-Addons modules in a standalone binary results in a
missing symbol callederror (#24614). Because the NAPI symbols are not exported in this mode. This PR should fix the issue.