Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linux canonicalization checks #24641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: linux canonicalization checks #24641

wants to merge 1 commit into from
+4 −2

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jul 18, 2024

No description provided.

@devsnek devsnek force-pushed the fix-linux-resolving branch 2 times, most recently from 1380b23 to 5e8a96b Compare July 18, 2024 15:31
@devsnek devsnek marked this pull request as ready for review July 18, 2024 15:31
bartlomieju
bartlomieju reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devsnek is there a test we could add?

@bartlomieju bartlomieju added this to the 2.0.0-rc.1 milestone Aug 26, 2024
nathanwhit
nathanwhit approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, though agree a test would be good

@bartlomieju bartlomieju modified the milestones: 2.0.0-rc.0, 2.0.0-rc.1 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@nathanwhit nathanwhit nathanwhit approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devsnek @bartlomieju @nathanwhit @littledivy