-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Deno.ConfigFile
#24630
feat: add Deno.ConfigFile
#24630
Conversation
* Note: It is recommended to only use this interface when dynamically | ||
* importing a JSON file that is not analyzable, as analyzable imports of JSON | ||
* files provide file-based type-hinting and autocompletion anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should be fact-checked on this, namely if the wording is accurate. These are based on what I found on my machine.
// To update, input the contents of `cli/schemas/config-file.v1.json` into | ||
// https://transform.tools/json-schema-to-typescript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naturally, the question would arise: how do we keep this interface up-to-date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against this: #24628 (comment)
* | ||
* @category Runtime | ||
*/ | ||
export interface ConfigFile { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be good to publish on JSR. For example, someone could generate this type from the deno schema file and have it behind a versioned API.
Closing as I think there's insufficient demand for this. |
Note: this hasn't yet reached consensus.
Closes #24628