feat: add Deno.ConfigFile
#24630
Closed
feat: add Deno.ConfigFile
#24630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Jul 18, 2024
Comment on lines
+6698
to
+6700
| * Note: It is recommended to only use this interface when dynamically | ||
| * importing a JSON file that is not analyzable, as analyzable imports of JSON | ||
| * files provide file-based type-hinting and autocompletion anyway. |
There was a problem hiding this comment.
I should be fact-checked on this, namely if the wording is accurate. These are based on what I found on my machine.
iuioiua
commented
Jul 18, 2024
Comment on lines
+6692
to
+6693
| // To update, input the contents of `cli/schemas/config-file.v1.json` into | ||
| // https://transform.tools/json-schema-to-typescript |
There was a problem hiding this comment.
Naturally, the question would arise: how do we keep this interface up-to-date?
dsherret
requested changes
Jul 18, 2024
dsherret
reviewed
Jul 18, 2024
| * | ||
| * @category Runtime | ||
| */ | ||
| export interface ConfigFile { |
There was a problem hiding this comment.
This would be good to publish on JSR. For example, someone could generate this type from the deno schema file and have it behind a versioned API.
|
Closing as I think there's insufficient demand for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this hasn't yet reached consensus.
Closes #24628