-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add --env-file as alternative to --env #24555
Conversation
0c5fb96
to
acaa9d9
Compare
cdd6238
to
3beb8a7
Compare
Figured it out now. Clap doesn't support two .long(), but it does allow an .alias() which is an extra hidden .long(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crowlKats , do you think it makes sense, and is technically possible with clap, to add a deprecation note to the |
@birkskyum clap itself can't do that, we'd have to do that ourselves (without much difficulty), however we are likely to keep it for the foreseeable future and then maybe remove it at some point |
Closes #24528, see comment here on Deno 2
deno --env-file
work like--env
#24528This pr rename --env to --env-file for several reasons (see issue), but allow --env to keep working as an alias.
I've added 2 unit tests to make sure both --env and --env-file work