fix: update lsp error message of 'relative import path' to 'use deno add' for npm/jsr packages #24524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add' for npm/jsr packages
|
Hello @lucacasonato , |
|
@nayeemrmn PTAL |
nayeemrmn
reviewed
Jul 22, 2024
nayeemrmn
reviewed
Jul 24, 2024
cli/lsp/diagnostics.rs
Outdated
| if let ResolveError::Other(resolve_error, ..) = (*error).as_ref() { | ||
| if let Some(ImportMapError::UnmappedBareSpecifier(specifier, _)) = resolve_error.downcast_ref::<ImportMapError>() { | ||
| if specifier.chars().next().unwrap_or('\0') == '@'{ | ||
| message = format!("Use [deno add {}] to add the dependency.", specifier); |
There was a problem hiding this comment.
I think the hint should be appended to the original message here.
dsherret
pushed a commit
that referenced
this pull request
Jul 26, 2024
…add' for npm/jsr packages (#24524)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #24033
Problem
LSP shows a message saying that the relative import path isn't prefixed with / or ./ or ../, while the package could be from npm or jsr.
Fix
This type of message arises when a Resolution error is received within the
fn to_lsp_diagnosticin cli/lsp/diagnostics.rs.Then a check is needed to see if the package name starts with @ in order to know if it's local or from npm/jsr.
After that the message can be updated to tell the user to use
deno addin order to add the dependency.Screenshot of the fix
