Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deno.json-importMap[deno add]): support inserting added dependencies into import map file when specified instead of deno.json #24478

Closed

Conversation

HasanAlrimawi
Copy link
Contributor

This PR serves as a starting point for addressing issue #24264 .

Flow
when using deno add "something", the program checks deno.json to see if it includes importMap key and if it does, the program adds the dependency there. However, if deno.json doesn't include the key, then the program adds the dependency under the imports key in deno.json.

Further work
If this feature is to be fully implemented using the approach in this PR, then the implementer should:

  1. Check importMap file if it already includes the dependency to be added to avoid redundancy.
  2. Handle mistyped/incorrectly-referenced importMap file.
  3. Apply further testing on different scenarios, as this is a starting point solution.

@bartlomieju
Copy link
Member

@dsherret can you please take a look at this one?

@bartlomieju bartlomieju added this to the 1.46 milestone Jul 22, 2024
@dsherret dsherret removed this from the 1.46 milestone Aug 20, 2024
@dsherret dsherret closed this in 37279e0 Aug 20, 2024
@dsherret
Copy link
Member

@HasanAlrimawi sorry, but we're going to decline this one for now. See the reasoning in #24264 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants