chore: add more TS/JS types #24472
Open
chore: add more TS/JS types #24472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing internal file mappings - Fix some obvious TS type errors
bartlomieju
reviewed
Jul 8, 2024
tools/core_ops.d.ts
Outdated
Comment on lines
1
to
5
| import { Buffer } from "node:buffer"; | ||
|
|
||
| export const op_add_main_module_handler: any; | ||
| export const op_base64_atob: any; | ||
| export const op_base64_btoa: any; |
There was a problem hiding this comment.
This will get out-of-sync really quickly with deno_core changes. It's probably better than nothing, but I wonder if we can force TSC to use typings coming from deno_core package.
There was a problem hiding this comment.
Fair point. I've reverted that part of the PR to keep the ops untyped for now as I couldn't find an obvious solution to ensure that the ops types don't go out of sync.
lucacasonato
reviewed
Jul 9, 2024
There was a problem hiding this comment.
With denoland/deno_core#814, remove this file and replace the import map entry with:
"ext:core/mod.js": "../../deno_core/core/core.d.ts",
|
@marvinhagemeister do you want to rebase this one? |
|
@marvinhagemeister bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more type errors left to fix, but this gets rid of a good chunk already.