-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): remove deprecation warnings #22120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -46,6 +46,8 @@ import { | |||
} from "ext:deno_node/internal_binding/async_wrap.ts"; | |||
import { codeMap } from "ext:deno_node/internal_binding/uv.ts"; | |||
|
|||
const DENO_RID_SYMBOL = Symbol.for("Deno.internal.rid"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const DENO_RID_SYMBOL = Symbol.for("Deno.internal.rid"); | |
const DENO_RID_SYMBOL = SymbolFor("Deno.internal.rid"); |
Nit: primordials.
I don't get it, although maybe take my opinion lightly.
|
Resource IDs are here to stay for some foreseeable future, but we want to make them an internal notion, so that we can migrate APIs to other mechanisms (like GCable objects like in #21999). This is a stop-gap solution to stop the warnings. I'm working on a better solution that will use a unique symbol to store resource IDs (this symbol will not be reachable by user code so you won't have a way to access the value of the field).
These appear to be the only ones that we missed :) |
Closes #22116