Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jupyter): don't require --unstable flag #21963

Merged
merged 3 commits into from
Jan 18, 2024
Merged

feat(jupyter): don't require --unstable flag #21963

merged 3 commits into from
Jan 18, 2024

Conversation

bartlomieju
Copy link
Member

This commit removes the requirement for --unstable flag in deno jupyter
subcommand. The process will no longer exit if this flag is not provided,
however the subcommand itself is still considered unstable and might
change in the future.

Required for #21452

@bartlomieju bartlomieju added this to the 1.40 milestone Jan 17, 2024
@bartlomieju bartlomieju requested a review from dsherret January 18, 2024 17:32
dsherret
dsherret approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/tools/jupyter/mod.rs
);
std::process::exit(70);
}
log::info!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bartlomieju bartlomieju merged commit 88bc57d into denoland:main Jan 18, 2024
14 checks passed
@bartlomieju bartlomieju deleted the unstable_jupyter branch January 18, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret