Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): align global deno worker type with deno.worker/webworker one #21936

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

jerome-benoit
Copy link
Contributor

@jerome-benoit jerome-benoit commented Jan 14, 2024

Transpilers doing type checking such as the ones used in dnt or bundler fail because of incompatible Worker types if env like browser are targeted.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
@jerome-benoit jerome-benoit changed the title fix(types): align global deno worker type with deno.worker one fix(types): align global deno worker type with deno.worker/webworker one Jan 14, 2024
@bartlomieju bartlomieju added this to the 1.40 milestone Jan 16, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tracking this down!

@bartlomieju bartlomieju enabled auto-merge (squash) January 18, 2024 22:19
@bartlomieju bartlomieju merged commit 99f9fa5 into denoland:main Jan 18, 2024
14 checks passed
@jerome-benoit jerome-benoit deleted the deno.worker-types branch January 19, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants