Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/kv): key expiration #20091

Merged
merged 8 commits into from
Aug 18, 2023
Merged

feat(ext/kv): key expiration #20091

merged 8 commits into from
Aug 18, 2023

Conversation

losfair
Copy link
Member

@losfair losfair commented Aug 7, 2023

No description provided.

@losfair losfair requested review from igorzi and lucacasonato August 7, 2023 20:44
ext/kv/interface.rs Outdated Show resolved Hide resolved
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add jsdoc documentation for this option.

cli/tsc/dts/lib.deno.unstable.d.ts Outdated Show resolved Hide resolved
ext/kv/interface.rs Outdated Show resolved Hide resolved
ext/kv/interface.rs Outdated Show resolved Hide resolved
@losfair losfair requested review from lucacasonato and igorzi August 8, 2023 14:10
@losfair losfair requested a review from lucacasonato August 8, 2023 17:33
@losfair losfair merged commit c77c836 into main Aug 18, 2023
@losfair losfair deleted the kv-ttl branch August 18, 2023 09:34
littledivy pushed a commit to littledivy/deno that referenced this pull request Aug 21, 2023
Co-authored-by: Luca Casonato <hello@lcas.dev>
littledivy pushed a commit that referenced this pull request Aug 21, 2023
Co-authored-by: Luca Casonato <hello@lcas.dev>
@xeaone
Copy link

xeaone commented Aug 21, 2023

Is this delete after expiration?

@xeaone
Copy link

xeaone commented Aug 21, 2023

Found answer to my question in this commit fafcbe4

Very excited for this thanks yall!

@exside
Copy link
Contributor

exside commented Aug 30, 2023

Awesome, just wanted to make an issue to get a feature like that, I'm lazy and don't want to manually clean up keys that are not relevant anymore, that feature is great! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants