Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): exclude files in deno.json "exclude" #19791

Merged
merged 4 commits into from
Jul 11, 2023
Merged

fix(lsp): exclude files in deno.json "exclude" #19791

merged 4 commits into from
Jul 11, 2023

Conversation

dsherret
Copy link
Member

Closes #19788

@dsherret dsherret requested a review from bartlomieju July 10, 2023 21:46
bartlomieju
bartlomieju approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 0d8af65 into denoland:main Jul 11, 2023
@dsherret dsherret deleted the fix_lsp_exclude_files_in_exclude branch July 11, 2023 01:03
@sgwilym sgwilym mentioned this pull request Aug 4, 2023
Closed
@sigmaSd sigmaSd mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp - Don't show diagnostics in excluded modules?
2 participants
@dsherret @bartlomieju