Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiment(ext/web): Don't expose event classes during the bootstrap phase #16213

Merged
merged 9 commits into from
Oct 24, 2022
Merged

experiment(ext/web): Don't expose event classes during the bootstrap phase #16213

merged 9 commits into from
Oct 24, 2022

Conversation

andreubotella
Copy link
Contributor

No description provided.

lucacasonato
lucacasonato reviewed Oct 9, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I've been wanting to do this for the longest time.

@andreubotella
Copy link
Contributor Author

I noticed after opening this PR that AbortSignal and AbortController are also exposed on the global during the bootstrap phase, so I think I'll change those as well and rename this PR.

@bartlomieju
Copy link
Member

@andreubotella is anything holding up this PR?

@andreubotella
Copy link
Contributor Author

andreubotella commented Oct 16, 2022 •
edited
Loading

@andreubotella is anything holding up this PR?

I wanted to also stop exposing AbortSignal and AbortController, and I had started working on that. But now builds on my machine won't work until #16304 is merged, so I guess this is good to land, and I'll work on that in a separate PR.

@bartlomieju
Copy link
Member

I'll merge that PR tonight so you should be unblocked.

@andreubotella andreubotella marked this pull request as ready for review October 16, 2022 19:27
bartlomieju
bartlomieju approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Andreu!

@bartlomieju bartlomieju added this to the 1.27 milestone Oct 22, 2022
@bartlomieju bartlomieju merged commit dbcbf53 into denoland:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
3 participants
@andreubotella @bartlomieju @lucacasonato