refactor(npm): create general use NpmPackageResolver
#15882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Sep 12, 2022
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct NpmPackageResolverSnapshot { |
There was a problem hiding this comment.
In the interest of time, I completely removed this for now and will add it back in the future when we actually go to implement lsp support.
ry
reviewed
Sep 13, 2022
| pub folder_path: PathBuf, | ||
| } | ||
|
|
||
| pub trait InnerNpmPackageResolver: Send + Sync { |
There was a problem hiding this comment.
Why "Inner" ? Usually I wouldn't expect that name exposed from a module
There was a problem hiding this comment.
I'm not sure about a name. It's exposed from this module, but private to cli/npm/resolvers (not exported from there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for a local node_modules folder resolver.
DenoDirNpmResolver->RequireNpmResolverGlobalNpmPackageResolverNpmPackageResolverthat has an internal implementation that can be swapped out.