Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime/workers): add close event #14327

Closed
wants to merge 1 commit into from
Closed

feat(runtime/workers): add close event #14327

wants to merge 1 commit into from

Conversation

duanckham
Copy link

The close event is emitted once the worker has closed. That will help the developer to handle the worker exit. And it is a little something like https://nodejs.org/api/worker_threads.html#event-exit.

@duanckham duanckham requested a review from bartlomieju as a code owner April 20, 2022 07:21
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@duanckham duanckham changed the title feat(runtime/workers): Add close event feat(runtime/workers): add close event Apr 20, 2022
@andreubotella
Copy link
Contributor

Deno's implementation of Worker follows the HTML spec, and the spec doesn't have such a close event. The relevant issue is whatwg/html#5869.

@duanckham
Copy link
Author

😫

@duanckham duanckham closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duanckham @CLAassistant @andreubotella