-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): include JSON modules in bundle #13188
Conversation
Note that this will output incorrect sourcemaps with This is not a blocker for this PR, but it should probably be fixed before the next patch release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Andreu has c good point regarding source maps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the two issues are fixed.
Yeah, I realised it when I did it that it would "mess" things up, but I plan to mop it up, along with other things as part of #13021. |
Fixes #13150