-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/crypto) - import ECDSA/ECDH P384 PKCS8/JWK #13154
feat(ext/crypto) - import ECDSA/ECDH P384 PKCS8/JWK #13154
Conversation
@littledivy @lucacasonato please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanwykes can you rebase? I'd like to land this before release on Thrusday
Done. WPT looks good. After landing, need to revise WebCrypto progress issue .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a tiny correction.
@seanwykes that's great! Shall I expect P-384 ECDH to land eventually or mark it as not supported by Deno? |
@panva Deno depends on an upstream package from |
Towards #11690.
Currently limitations in
p386
crate, related to missingProjectiveArithmetic
trait, do not allow import of P384 private keys, since we must validate the key before importing. On the other hand,ring
crate supports parsing PKCS#8 but does not give access to internals.PR uses der::asn1 to implement a parser/builder for PKCS#8 EC private keys, with import_key.rs altered to import ECDSA/ECDH PKCS#8 and JWK for both P256 and P384.