fix(test): wait for inspector session in side modules #13065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespertheend
changed the title
|
Thanks @jespertheend this indeed fixes the problem with debugging tests. I'll add a test case and land it for v1.17 |
bartlomieju
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12584
This the first time I've ever worked with rust so apologies if this a terrible PR.
All tests passed locally except for
test_respect_cache_revalidateswhich was already failing without this change.One thing I was a bit worried about was that this change would cause multiple breaks every time a new module is loaded. But I couldn't find any case where this happens.
Also, should a new test case for this specific issue be added? I couldn't find any existing tests checking for the inspector like this, so I'm not sure I'm capable of writing such a test case.