Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/crypto): implement HKDF operations #11865

Merged
merged 9 commits into from
Sep 11, 2021
Merged

feat(ext/crypto): implement HKDF operations #11865

merged 9 commits into from
Sep 11, 2021

Conversation

littledivy
Copy link
Member

Towards #11690

@littledivy @lucacasonato
strict null check
e7ee696 
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
lucacasonato
lucacasonato approved these changes Aug 29, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS looks good. @bnoordhuis PTAL too

@bartlomieju bartlomieju requested a review from bnoordhuis August 31, 2021 13:19
@bartlomieju bartlomieju added this to the 1.14.0 milestone Sep 4, 2021
ry
ry approved these changes Sep 11, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @littledivy

@ry ry merged commit 0cb22d4 into denoland:main Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@ry ry ry approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@littledivy @ry @lucacasonato @bartlomieju