feat(ext/crypto): import JWK key for HMAC #11716
Conversation
| if (keyUsages.length == 0) { | ||
| throw new DOMException("Key usage is empty", "SyntaxError"); | ||
| } |
There was a problem hiding this comment.
Where does the spec say to do this?
There was a problem hiding this comment.
https://w3c.github.io/webcrypto/#SubtleCrypto-method-importKey (importKey Step 9)
ext/crypto/00_crypto.js
Outdated
| StringPrototypeSplit( | ||
| atob( | ||
| StringPrototypeReplace( | ||
| StringPrototypeReplace(key, /\-/g, "+"), |
There was a problem hiding this comment.
Using split() and replace() has the (global, user visible) side effect of clobbering RegExp.$_, etc.
(Aside: I also feel this code is really hard to read.)
There was a problem hiding this comment.
@littledivy Can you split this across multiple lines rather than nesting these calls?
There was a problem hiding this comment.
Done (also made it a bit more readable)
| // 7. | ||
| if ( | ||
| normalizedAlgorithm.length > length || | ||
| normalizedAlgorithm.length <= (length - 8) |
There was a problem hiding this comment.
This looks kind of weird to me. length === data.byteLength * 8 so is this trying to say if (length !== normalizedAlgoritm.length) in a roundabout way?
There was a problem hiding this comment.
It expresses the following:
Towards #11690