Fix clippy warnings #1149
Merged
Fix clippy warnings #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run with:
$ DENO_BUILD_PATH=`pwd`/out/debug cargo clippy
There's still one remaining:
```
warning: Try not to call a closure in the expression where it is declared.
--> src/ops.rs:1128:36
|
1128 | Box::new(futures::future::result((move || {
| ____________________________________^
1129 | | // TODO properly parse addr
1130 | | let addr = SocketAddr::from_str(address).unwrap();
1131 | |
... |
1148 | | ))
1149 | | })()))
| |______^
|
= note: #[warn(clippy::redundant_closure_call)] on by default
= help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#redundant_closure_call
help: Try doing something like:
|
1128 | Box::new(futures::future::result({
1129 | // TODO properly parse addr
1130 | let addr = SocketAddr::from_str(address).unwrap();
1131 |
1132 | let listener = TcpListener::bind(&addr)?;
1133 | let resource = resources::add_tcp_listener(listener);
```
https://github.com/rust-lang-nursery/rust-clippy
ry
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run with:
$ DENO_BUILD_PATH=`pwd`/out/debug cargo clippyThere's still one
remainingsuppressed (due to rust-lang/rust-clippy#1684)https://github.com/rust-lang-nursery/rust-clippy