Upgrade Flatbuffers. #1127
Merged
Upgrade Flatbuffers. #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use msg_generated.rs as mod instead of crate.
ry
force-pushed
the
upgrade_flatbuffers
branch
from
8b375ee to
7bba86b
Compare
piscisaureus
requested changes
Oct 31, 2018
BUILD.gn
Outdated
| @@ -124,8 +123,12 @@ ts_sources = [ | |||
| rust_executable("deno") { | |||
| source_root = "src/main.rs" | |||
| extern = main_extern | |||
| data = [ | |||
There was a problem hiding this comment.
Actually, it seems that the deno_bin.d depfile now include msg_generated.d - rust is smart enough to detect include!() it seems. I removed this.
build_extra/rust/rust.gni
Outdated
| @@ -49,6 +49,7 @@ template("rust_crate") { | |||
| "crate_type", | |||
| "crate_version", | |||
| "deps", | |||
| "data", | |||
There was a problem hiding this comment.
Not needed. We do not have any data deps for any rust targets.
build_extra/rust/rust.gni
Outdated
| @@ -170,7 +170,7 @@ template("rust_crate") { | |||
| "rustc", | |||
| rebase_path(source_root, root_build_dir), | |||
| "--env-out-dir", | |||
| rebase_path(root_out_dir), | |||
| rebase_path(out_dir, root_out_dir), | |||
There was a problem hiding this comment.
Should probably rebased with "//src" as the second arg.
There was a problem hiding this comment.
Or with // and add an extra .. to the include!
ry
force-pushed
the
upgrade_flatbuffers
branch
from
54691a1 to
2ce5113
Compare
piscisaureus
approved these changes
Oct 31, 2018
Closed
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 5, 2018
- Performance and stability improvements on all platforms. - Add repl (denoland#998) - Add deno.Buffer (denoland#1121) - Support cargo check (denoland#1128) - Upgrade Rust crates and Flatbuffers. (denoland#1145, denoland#1127) - Add helper to turn deno.Reader into async iterator (denoland#1130) - Add ability to load JSON as modules (denoland#1065) - Add deno.resources() (denoland#1119) - Add application/x-typescript mime type support (denoland#1111)
Merged
ry
added a commit
that referenced
this pull request
Nov 5, 2018
- Performance and stability improvements on all platforms. - Add repl (#998) - Add deno.Buffer (#1121) - Support cargo check (#1128) - Upgrade Rust crates and Flatbuffers. (#1145, #1127) - Add helper to turn deno.Reader into async iterator (#1130) - Add ability to load JSON as modules (#1065) - Add deno.resources() (#1119) - Add application/x-typescript mime type support (#1111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use msg_generated.rs as mod instead of crate.
This overlaps in functionality provided by #1125...