refactor(cli): move test reporting into a trait #10408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
caspervonb
force-pushed
the
refactor-move-test-reporting-into-a-reporter-trait
branch
2 times, most recently
from
1f38628 to
4fd0fca
Compare
caspervonb
force-pushed
the
refactor-move-test-reporting-into-a-reporter-trait
branch
from
4fd0fca to
d194660
Compare
bartlomieju
reviewed
Apr 28, 2021
bartlomieju
approved these changes
Apr 29, 2021
caspervonb
deleted the
refactor-move-test-reporting-into-a-reporter-trait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves test reporting into a trait in preparation for supporting more reporters, like json and terse.
The output remains unchanged and there's still room to clean up some small things later.