thread 'main' has overflowed its stack using Deno bundle (Windows)

[dragonstyle]

When running deno bundle on Windows: deno bundle --unstable --importmap=src/import_map.json src/quarto.ts package/dist/bin/quarto.js I receive the error

thread 'main' has overflowed its stack

and bundling fails. The same command succeeds on macos/posix platforms. The error appeared starting in Deno v1.8.0 and persists in v1.8.1. We were previously using v1.7.5 without issue.

I suspect the issue may be related to a circular dependency with the following modules:

DEBUG RS - swc_bundler::bundler::load:83 - (ModuleId(54), #572, #573) Storing module: 
<https://deno.land/std@0.90.0/path/mod.ts>
DEBUG RS - swc_bundler::bundler::load:83 - (ModuleId(66), #596, #597) Storing module: 
<https://deno.land/std@0.90.0/path/glob.ts>

because the debug information for windows is full of:

DEBUG RS - swc_bundler::bundler::chunk::plan:618 - Circular dep: ModuleId(54) => ModuleId(66)
DEBUG RS - swc_bundler::bundler::chunk::plan:618 - Circular dep: ModuleId(54) => ModuleId(66)
DEBUG RS - swc_bundler::bundler::chunk::plan:618 - Circular dep: ModuleId(54) => ModuleId(66)
DEBUG RS - swc_bundler::bundler::chunk::plan:618 - Circular dep: ModuleId(54) => ModuleId(66)

I've attached the debug output for the bundle command as well as the deno info for the module:

Info -- Json
Bundle -- Debug Output

I haven't been able to create a standalone repro case outside of our module. Is there other information that I can provide to be helpful?

[kitsonk]

cc/ @kdy1

[kdy1]

Log for circular imports are not related to stack overflow.
Can you run it again with RUST_MIN_STACK (environment variable) set to 8388608?

[dragonstyle]

Just ran it again after setting that env variable and it didn't appear to make a difference. Same thread 'main' has overflowed its stack error.

bundle.debug.txt

[kdy1]

@dragonstyle Thanks!

[kdy1]

It works on my machine if I set RUST_MIN_STACK as 8388608

[dragonstyle]

Perhaps I'm not setting the stack size correctly - here is the simple case I'm using

C:\Users\charlesteague\Development\quarto-cli\package\src>C:\Users\charlesteague\Development\quarto-cli\package\dist\bin\deno --version
deno 1.8.1 (release, x86_64-pc-windows-msvc)
v8 9.0.257.3
typescript 4.2.2

C:\Users\charlesteague\Development\quarto-cli\package\src>set RUST_MIN_STACK=8388608

C:\Users\charlesteague\Development\quarto-cli\package\src>echo %RUST_MIN_STACK%
8388608

C:\Users\charlesteague\Development\quarto-cli\package\src>C:\Users\charlesteague\Development\quarto-cli\package\dist\bin\deno bundle --unstable --importmap=C:\Users\charlesteague\Development\quarto-cli\src\import_map.json C:\Users\charlesteague\Development\quarto-cli\src\quarto.ts C:\Users\charlesteague\Development\quarto-cli\package\dist\bin\quarto.js
Bundle file:///C:/Users/charlesteague/Development/quarto-cli/src/quarto.ts
Check file:///C:/Users/charlesteague/Development/quarto-cli/src/quarto.ts

thread 'main' has overflowed its stack

C:\Users\charlesteague\Development\quarto-cli\package\src>

[kdy1]

Fixed on upstream

[dragonstyle]

@kdy1 Thanks so much for fixing this promptly. @kitsonk I'm not sure how to tell when to expect this in a Deno release- can you give me any guidance (e.g. will it just get included in the next release now that the fix is available)?

Been really enjoying working with Deno- thank both of you for all your work on it!

[kitsonk]

Should be in Deno 1.9 (next week).

[bartlomieju]

Fixed in 1.9.0

[dragonstyle]

Confirmed- we are back in business on 1.9. Thank you!

[StoneCypher]

Respectfully, @bartlomieju , I believe I have found another instance of this fault in #15117. I cannot be certain.