Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaces: Do not allow to use two different workspaces in subcommands that accept multiple entrypoints #24160

Closed
Tracked by #22942
bartlomieju opened this issue Jun 9, 2024 · 0 comments · Fixed by #24334
Assignees
Labels
feat new feature (which has been agreed to/accepted)

Comments

@bartlomieju
Copy link
Member

bartlomieju commented Jun 9, 2024

Deno has several subcommands that accept multiply entrypoints, eg:

deno lint <file1> <file2> <dir1>
deno fmt <file1> <dir1>

We don not want to support running these commands on two separate workspaces like so:

deno lint workspace1/ workspace2/

However it should be possible to run on 2 different packages from the same workspace like so:

deno lint workspace1/package1/ workspace1/package2/

denoland/deno_config#55 should be addressed first

@lucacasonato lucacasonato added the feat new feature (which has been agreed to/accepted) label Jun 10, 2024
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
Adds much better support for the unstable Deno workspaces as well as
support for npm workspaces. npm workspaces is still lacking in that we
only install packages into the root node_modules folder. We'll make it
smarter over time in order for it to figure out when to add node_modules
folders within packages.

This includes a breaking change in config file resolution where we stop
searching for config files on the first found package.json unless it's
in a workspace. For the previous behaviour, the root deno.json needs to
be updated to be a workspace by adding `"workspace":
["./path-to-pkg-json-folder-goes-here"]`. See details in
denoland/deno_config#66

Closes denoland#24340
Closes denoland#24159
Closes denoland#24161
Closes denoland#22020
Closes denoland#18546
Closes denoland#16106
Closes denoland#24160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants