-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add footnote support #94
Conversation
Sorry @hashrock, that was possibly the worst PR I've ever created. The feature wasn't at all working 😭 But on the positive side, it's now working and there are really good tests. Here's what's changed:
|
Waiting on #99 so that the server test is cleaner and more useful. |
Hi @crowlKats, if you could jump in here again, that'd be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #6
Someone created a marked extension late last year. I guess it works well enough. For the test I basically just took the example from upstream: https://raw.githubusercontent.com/bent10/marked-extensions/main/packages/footnote/test/fixtures/example.md
@hashrock, please take a look.