-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TLS #154
Support TLS #154
Conversation
e348518
to
4caa9c4
Compare
810ea19
to
7ceea56
Compare
9a0d77d
to
445fb1f
Compare
@lideming PTAL, this pr lacks tests but I think it is also ready for review. I will continue trying to add test for it |
@uki00a can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shiyuhang0 Nice work! I've left a few comments, but otherwise it looks good to me overall
@lideming Could you PTAL if you have time?
@uki00a Thank you for your review and I have optimized the code according to your comment. PTAL again. This test will fail with the following message:
But it is not the fault of this pr, it will fail even in master #160. I think we can skip this test in this pr and open another pr to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
@lideming can this pr be merged? |
close #118
works based on @codeflows, thanks for his excellent work.
Implement
I think there is no need to implement TLS handshake ourselves, we can just use
Deno.startTls
to do that. Thus, TLS will be limited by it. I have opened a PR request for more abilities denoland/deno#18851Configurations
provide two configurations
Deno.startTls
Test
compatibility
Deno.startTls
handles the TLS. For example, how to verify hostname