-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump go-libp2p version to v0.17.0 to add hole punching support #19
Conversation
Awesome! Thanks a lot for the PR! Not sure if you read it, but this comes right in time as we were just discussing this in #18! Unfortunately, I will only have time to take a look at it next week, but this will most likely land in here :) |
Good to known that. And then you could check the mdns issue also :) |
Amazing! Was just wondering if |
@optman I filed a PR against your PR with a fix for the mDNS discovery. However, the decentralized hole punching documentation suggests a more involved connection handling than currently implemented. I have the chance to chat with some libp2p devs in a couple of weeks and will bring that up then. |
can you upload compiled windows binary? |
Feel free to keep this PR open. Just yesterday I had the chance to catch up with some of the devs and he mentioned the missing option:
I'll test this branch with the above additional option and would leave feedback here or make changes right away. |
I just notice the PR is on based on the wrong branch, it contains many unrelated commits. Anyway, you have merged the code on distributed-hole-punching branch. I don't think |
mdns compiled but not works, no idea why.