Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with TVPs #622

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed issues with TVPs #622

wants to merge 3 commits into from

Conversation

Woody1193
Copy link

This PR fixes two recently uploaded issues wherein TVP checking will fail if the value was a slice of pointers and where TVP will not ignore internal fields.

@NikitaDef
Copy link
Contributor

Can you write the any test? I don't understand your fix

@Woody1193
Copy link
Author

Ah, my apologies. I dug into the code a little more and discovered that I hadn't implemented the changes correctly. Essentially, these are supposed to support conversion of a slice of pointers to a TPV and to ignore unexported fields when converting TPV data to SQL data.

@kardianos
Copy link
Collaborator

This change alters renames a number of existing fields. Please revert. Please also document what type of values this accepts, include in comments with examples of what this solves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants