Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nullable version of uniqueidentifier #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeebiq
Copy link

@jeebiq jeebiq commented Sep 29, 2020

No description provided.

@denisenkom
Copy link
Owner

Why do you think this is the right way of adding new type support?

@jeebiq
Copy link
Author

jeebiq commented Nov 4, 2020

I didn't see anything in the readme about how you wished to have anything new added, so I added as new/dedicated files to keep it as simple as possible for me without touching the existing code.

@denisenkom
Copy link
Owner

You need to add a roundtrip test with the actual SQL server. One test should set a value in the SQL and read it uniqueidentifier. Another test should verify sending uniqueidentifier value into SQL server and then read it back and compare with original. Each test should test actual value and NULL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants