sqlserver: update test DSN string to be more flexible #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kardianos
force-pushed
the
kardianos-azure-test
branch
from
c2a55c8
to
f45cb58
Compare
Support URL for test DSN, allows setting properties (such as encryption). Also fix URL query parameter parsing by forcing keys to lower case that are expected. Add a failing test case for Azure Database to be fixed in a later commit.
kardianos
force-pushed
the
kardianos-azure-test
branch
from
f45cb58
to
2c7ad9a
Compare
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
…adme Fill out MIGRATIONS.md with migration format and best practice notes
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
…ql (denisenkom#265) * Fix in the URL parser with go 1.12.8 and github.com/go-sql-driver/mysql Change schemeFromURL to just split the url by :// to find the scheme. It's not required to parse the whole URL. MySQL DSNs aren't valid URLs. Fixes denisenkom#264 * The mysql driver itself also used net/url.Parse * Also fix TestPasswordUnencodedReservedURLChars * Keep backwards compatibility with url encoded username and passwords * Fix suggestions * Reuse old function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support URL for test DSN, allows setting properties (such as
encryption).
Also fix URL query parameter parsing by forcing keys to lower case
that are expected.