-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open preview buttons for context menus #1906
feat: open preview buttons for context menus #1906
Conversation
This is useful for commands that get opts passed in by VSCode, for example Show Preview.
… to default preview for files outside engine
…uttons-for-context-menus
ef96e26
to
36381d6
Compare
…uttons-for-context-menus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When switching between regular preview and dendron preview, this adds complexity to the users:
- when the user navigates from a dendron markdown file to a regular markdown file outside of Dendron, the preview will stop working and it won't be clear that they have to click the preview again
- the same problem happens vice versa except its a little more insidious because the builtin preview will try to render dendron markdown and will fail at dendron specific syntax
Instead of toggling between previews, can we use the Dendron preview for all markdown files?
This will require the following change: [[Dendron Should Show Regular Markdown|dendron://private/task.views.2021.12.16.dendron-should-show-regular-markdown]]
…uttons-for-context-menus
This is actually a bit more involved because the preview asks the engine to render the note, but only passes in the id of the note. I'll need to update the API to allow overriding the note body. |
Combined with the following PR, this will replace the default "Show Preview" context menu buttons with Dendron's: microsoft/vscode#139241