Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move utilities to a separate file. #82

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

sentilesdal
Copy link
Contributor

Consolidates the utility functions like tuple_to_dataclass to a utilities.py file. This reduces duplicated code in the generated Contract.py files.

  • move utilities to a separate file
  • regenerate types
  • update snapshots

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 155 lines in your changes are missing coverage. Please review.

Comparison is base (36e61a3) 73.67% compared to head (30317d4) 72.03%.

Files Patch % Lines
pypechain/test/events/types/utilities.py 6.06% 31 Missing ⚠️
pypechain/test/overloading/types/utilities.py 6.06% 31 Missing ⚠️
pypechain/test/deployment/types/utilities.py 9.09% 30 Missing ⚠️
pypechain/test/return_types/types/utilities.py 24.24% 25 Missing ⚠️
example/types/utilities.py 27.27% 24 Missing ⚠️
example/types/ExampleContract.py 50.00% 5 Missing ⚠️
...est/overloading/types/OverloadedMethodsContract.py 33.33% 4 Missing ⚠️
pypechain/main.py 33.33% 2 Missing ⚠️
pypechain/templates/utilities.py 93.93% 2 Missing ⚠️
pypechain/test/events/types/EventsContract.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   73.67%   72.03%   -1.64%     
==========================================
  Files          32       38       +6     
  Lines        1679     1670       -9     
==========================================
- Hits         1237     1203      -34     
- Misses        442      467      +25     
Flag Coverage Δ
unittests 72.03% <35.95%> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sentilesdal sentilesdal merged commit df75d87 into main Dec 15, 2023
6 checks passed
@sentilesdal sentilesdal deleted the matt-consolidate-utility-functions branch December 15, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants