Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for generated init file #61

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Unit test for generated init file #61

merged 6 commits into from
Nov 28, 2023

Conversation

slundqui
Copy link
Contributor

No description provided.

@slundqui slundqui requested a review from sentilesdal November 28, 2023 18:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9bf7b4e) 72.85% compared to head (d08354b) 72.88%.

Files Patch % Lines
pypechain/render/init.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   72.85%   72.88%   +0.03%     
==========================================
  Files          20       21       +1     
  Lines         851      852       +1     
==========================================
+ Hits          620      621       +1     
  Misses        231      231              
Flag Coverage Δ
unittests 72.88% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with name change to init.py and init_test.py

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx

@slundqui slundqui merged commit 7d4d8e1 into main Nov 28, 2023
3 checks passed
@slundqui slundqui deleted the slundquist-import-test branch November 28, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants