Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input parameter names and types. #39

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

sentilesdal
Copy link
Contributor

There were a few issues with structs being used as input parameters showing as 'tuple' instead of the struct type. The names were also not coming through as the default 'arg' names if they were blank. both issues fixed now.

  • cleanup names, multimethod attribute in template
  • add more example abis
  • update snapshots

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aab5a29) 66.79% compared to head (ac8c0a1) 66.85%.

Files Patch % Lines
pypechain/utilities/abi.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   66.79%   66.85%   +0.06%     
==========================================
  Files          17       17              
  Lines         527      528       +1     
==========================================
+ Hits          352      353       +1     
  Misses        175      175              
Flag Coverage Δ
unittests 66.85% <87.50%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sentilesdal sentilesdal merged commit c09a57e into main Nov 17, 2023
@sentilesdal sentilesdal deleted the matt-fix-param-input-types branch November 17, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants